spdm_device_secret_lib_sample: Fix build when GET_KEY_PAIR_INFO_CAP is disabled#3659
Merged
Merged
Conversation
jyao1
reviewed
Jun 22, 2026
alistair23
force-pushed
the
alistair/key-pai-fixup
branch
from
1e98928 to
95ed039
Compare
jyao1
reviewed
Jun 23, 2026
…s disabled Commit 1e16c60 broke builds when LIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP is not enabled as libspdm_get_key_pair_id_by_slot() isn't defined. Fix the build by guarding calls of libspdm_get_key_pair_id_by_slot(). Fixes: 1e16c60 ("Add slot 4 multi-key example with a distinct responder leaf key") Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/key-pai-fixup
branch
from
95ed039 to
91f2c9a
Compare
jyao1
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1e16c60 broke builds when
LIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP is not enabled as libspdm_get_key_pair_id_by_slot() isn't defined. Fix the build by guarding calls of libspdm_get_key_pair_id_by_slot().
Fixes: 1e16c60 ("Add slot 4 multi-key example with a distinct responder leaf key")